linux-kernel - Re: [PATCH v2 5/9] dt_bindings: rs485: Correct delay values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220705203827.GA2583869-robh@kernel.org>
Date:   Tue, 5 Jul 2022 14:38:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     linux-kernel@...r.kernel.org, ilpo.jarvinen@...ux.intel.com,
        vz@...ia.com, devicetree@...r.kernel.org,
        Lino Sanfilippo <l.sanfilippo@...bus.com>,
        linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org,
        andriy.shevchenko@...ux.intel.com, p.rosenberger@...bus.com,
        krzysztof.kozlowski+dt@...aro.org, lukas@...ner.de,
        jirislaby@...nel.org, robh+dt@...nel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 5/9] dt_bindings: rs485: Correct delay values

On Sun, 03 Jul 2022 19:00:35 +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@...bus.com>
> 
> Currently the documentation claims that a maximum of 1000 msecs is allowed
> for RTS delays. However nothing actually checks the values read from device
> tree/ACPI and so it is possible to set much higher values.
> 
> There is already a maximum of 100 ms enforced for RTS delays that are set
> via the uart TIOCSRS485 ioctl. To be consistent with that use the same
> limit for DT/ACPI values.
> 
> Although this change is visible to userspace the risk of breaking anything
> when reducing the max delays from 1000 to 100 ms should be very low, since
> 100 ms is already a very high maximum for delays that are usually rather in
> the usecs range.
> 
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@...bus.com>
> ---
>  Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>