linux-kernel - RE: [PATCH v4 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SA2PR11MB487472B96E8B1FBC0B50424A92819@SA2PR11MB4874.namprd11.prod.outlook.com>
Date:   Tue, 5 Jul 2022 06:36:01 +0000
From:   <Kavyasree.Kotagiri@...rochip.com>
To:     <robh@...nel.org>
CC:     <Nicolas.Ferre@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <Claudiu.Beznea@...rochip.com>, <krzysztof.kozlowski@...aro.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v4 1/3] dt-bindings: mfd: atmel,flexcom: Convert to
 json-schema

> > > > Convert the Atmel flexcom device tree bindings to json schema.
> > > >
> > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> > > > ---
> > > > v3 -> v4:
> > > >  - Corrected format of enum used for compatible string.
> > > >
> > > > v2 -> v3:
> > > >  - used enum for compatible string.
> > > >  - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > > >  - fixed dtschema errors.
> > > >
> > > > v1 -> v2:
> > > >  - Fix title.
> > > >
> > > >  .../bindings/mfd/atmel,flexcom.yaml           | 104 ++++++++++++++++++
> > > >  .../devicetree/bindings/mfd/atmel-flexcom.txt |  63 -----------
> > > >  2 files changed, 104 insertions(+), 63 deletions(-)
> > > >  create mode 100644
> > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> > > >  delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> > > flexcom.txt
> > > >
> > >
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > >
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> > >
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > >
> > >
> > > flexcom@...00000: spi@400:compatible:0: 'atmel,at91rm9200-spi' was
> > > expected
> > >         arch/arm/boot/dts/at91-sam9x60ek.dtb
> > >
> > > flexcom@...00000: spi@400:compatible: ['microchip,sam9x60-spi',
> > > 'atmel,at91rm9200-spi'] is too long
> > >         arch/arm/boot/dts/at91-sam9x60ek.dtb
> >
> > These errors are expected because "microchip,sam9x60-spi" and
> "atmel,at91rm9200-spi"
> > are documented in Documentation/devicetree/bindings/spi/spi_atmel.txt.
> > which I added in description as
> > " description: See ../spi/spi_atmel.txt for details of SPI bindings."
> 
> If that was still true, there would not be a warning because .txt files
> don't cause warnings. You've defined the SPI compatible here and that
> doesn't agree with the dts files. One of them is wrong.
> 
> Normally, child nodes either just reference another schema or document
> everything locally. You've done a mixture which is not right. Presumably
> that was to avoid 'undocumented compatible' warnings. To fix that you
> either need to convert the SPI binding or don't use it in the example.
> 
For now, I will remove the spi node from example and send my v6 patch series.
I will add it back once below patch is accepted:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
Please let me know your comments. 

> Rob