linux-kernel - Re: [PATCH v3] mm, hugetlb: skip irrelevant nodes in show_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220705142547.da3ea5a7383a7eeec3a93665@linux-foundation.org>
Date:   Tue, 5 Jul 2022 14:25:47 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Gang Li <ligang.bdlg@...edance.com>
Cc:     Mike Kravetz <mike.kravetz@...cle.com>,
        Muchun Song <songmuchun@...edance.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mm, hugetlb: skip irrelevant nodes in
 show_free_areas()

On Tue,  5 Jul 2022 17:21:19 +0800 Gang Li <ligang.bdlg@...edance.com> wrote:

> show_free_areas() allows to filter out node specific data which is
> irrelevant to the allocation request. But hugetlb_show_meminfo() still
> shows hugetlb on all nodes, which is redundant and unnecessary.
> 
> Use show_mem_node_skip() to skip irrelevant nodes. And replace
> hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid).

It would be helpful to include before-and-after sample output text in
the changelog to help others assess the proposed change.

> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6202,7 +6202,11 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask)
>  		printk(KERN_CONT "= %lukB\n", K(total));
>  	}
>  
> -	hugetlb_show_meminfo();
> +	for_each_online_node(nid) {
> +		if (show_mem_node_skip(filter, nid, nodemask))
> +			continue;
> +		hugetlb_show_meminfo_node(nid);
> +	}
>  

Does this mean that potentially useful info about presently-offline
nodes will no longer be available?