linux-kernel - Re: [PATCH] ALSA: hda/cs8409: change cs8409

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r130vw7k.wl-tiwai@suse.de>
Date:   Tue, 05 Jul 2022 09:45:51 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Tom Rix <trix@...hat.com>
Cc:     perex@...ex.cz, tiwai@...e.com, vitalyr@...nsource.cirrus.com,
        sbinding@...nsource.cirrus.com, tanureal@...nsource.cirrus.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static

On Mon, 04 Jul 2022 16:28:36 +0200,
Tom Rix wrote:
> 
> sparse reports
> sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static?
> 
> cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an
> initializer for the hda_fixup element v.pins.  Both are defined in the
> patch_cs8408-table.c file but only cs8409_fixups is used externally in
> patch_cs8409.c.  So cs8409_cs42l42_pincfgs_no_dmic should have a static
> storage class specifier.
> 
> The other v.pins initializers in cs8409_fixups table, though declared
> extern in patch_cs8409.h are also only used in patch_cs8409-tables.c.
> So change all the v.pins initializers to static.
> 
> Fixes: 9e7647b5070f ("ALSA: hda/cs8409: Move arrays of configuration to a new file")
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks, applied now.


Takashi