linux-kernel - Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUYCiRC+9UnQB6-2XGp+wOjYq1U_J3bDQT+WNm==mS4qg@mail.gmail.com>
Date:   Tue, 5 Jul 2022 11:43:52 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Max Staudt <max@...as.org>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        linux-can@...r.kernel.org,
        Vincent Mailhol <vincent.mailhol@...il.com>,
        Oliver Neukum <oneukum@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters

Hi Max,

On Mon, Jun 27, 2022 at 7:10 PM Max Staudt <max@...as.org> wrote:
> On Mon, 27 Jun 2022 17:05:57 +0200
> Marc Kleine-Budde <mkl@...gutronix.de> wrote:
> > On 18.06.2022 21:50:31, Max Staudt wrote:
> > > This is the can327 driver. It does a surprisingly good job at
> > > turning ELM327 based OBD-II interfaces into cheap CAN interfaces
> > > for simple homebrew projects.
> > >
> > > Please see the included documentation for details and limitations:
> > > Documentation/networking/device_drivers/can/can327.rst
> > >
> > > Cc: linux-can <linux-can@...r.kernel.org>
> > > Signed-off-by: Max Staudt <max@...as.org>
> > > Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> >
> > Added with some minor coding style improvements (line breaks and
> > whitespace changes) to make checkpatch and clang-format happier to
> > can-next/master!
>
> Wonderful, thank you!

Thanks for your patch, which is now commit 43da2f07622f4137 ("can:
can327: CAN/ldisc driver for ELM327 based OBD-II adapters") in
linux-can-next/master

> (+CC: Greg, Oliver Hartkopp)
>
> This quite fittingly marks the end of an era for me, so I would like to
> thank everyone involved, more or less in order of appearance:
>
> Oliver Hartkopp    for slcan (the inspiration) and related feedback.
> Oliver Neukum      for the first reviews, before this went public.
> Marc Kleine-Budde  for upstream guidance.
> Greg Kroah-Hartman for TTY and style support.
> Vincent Mailhol    for intensive reviews up until the end.
>
> ...and of course thanks to the numerous people I've been in touch with
> via GitHub and otherwise. Bug reports, testing, or simply thanks and
> encouragement - they have all helped.
>
> Some stats for those interested: It has been a solid 8 years since the
> idea for this driver was born in 2014, with occasional on and off work
> on it since. The oldest code is from 2015, running in userspace and
> injecting packets via vcan. It became a kernel module in 2016, with
> link settings via "ip link". The first public version was released in
> 2018. It then gained in popularity, making upstreaming... inevitable ;)

So development started before commit cd6484e1830be260 ("serdev:
Introduce new bus for serial attached devices").  I guess that is the
reason why this driver uses a line discipline, instead of the serial
bus?

I had a quick glance through the various revisions posted, and it
doesn't seem like anyone mentioned the serial bus.  Would there be
any advantage in migrating to the serial bus?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds