linux-kernel - Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220705115613.69d32b22.max@enpas.org>
Date:   Tue, 5 Jul 2022 11:56:13 +0200
From:   Max Staudt <max@...as.org>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>, linux-can@...r.kernel.org,
        Vincent Mailhol <vincent.mailhol@...il.com>,
        Oliver Neukum <oneukum@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters

On Tue, 5 Jul 2022 11:49:27 +0200
Marc Kleine-Budde <mkl@...gutronix.de> wrote:

> On 05.07.2022 11:43:52, Geert Uytterhoeven wrote:
> > So development started before commit cd6484e1830be260 ("serdev:
> > Introduce new bus for serial attached devices").  I guess that is
> > the reason why this driver uses a line discipline, instead of the
> > serial bus?
> > 
> > I had a quick glance through the various revisions posted, and it
> > doesn't seem like anyone mentioned the serial bus.  Would there be
> > any advantage in migrating to the serial bus?  
> 
> Does serial bus work with hot plug devices like USB Serial Adapters
> and/or devices that are not described in the device tree?

This is indeed the reason. The device cannot be autodetected, as the
UART has no identifying information (USB VID/PID or the like, and don't
forget the BT variants) attached to it, hence the manual attachment.


Max