[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f6e9bba4-6ffc-7df9-152d-caae0c90f1b2@linaro.org>
Date: Tue, 5 Jul 2022 12:19:33 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Johan Hovold <johan+linaro@...nel.org>,
Vinod Koul <vkoul@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Kishon Vijay Abraham I <kishon@...com>,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/43] dt-bindings: phy: qcom,qmp: split out UFS PHY
binding
On 05/07/2022 11:42, Johan Hovold wrote:
> The QMP PHY DT schema is getting unwieldy. Break out the UFS PHY
> binding in a separate file.
>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
> .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 65 --------
> .../bindings/phy/qcom,qmp-ufs-phy.yaml | 149 ++++++++++++++++++
> 2 files changed, 149 insertions(+), 65 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index f416a1a53a3f..04c24f8e4526 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -19,32 +19,21 @@ properties:
> enum:
> - qcom,ipq6018-qmp-usb3-phy
> - qcom,ipq8074-qmp-usb3-phy
> - - qcom,msm8996-qmp-ufs-phy
> - qcom,msm8996-qmp-usb3-phy
> - - qcom,msm8998-qmp-ufs-phy
> - qcom,msm8998-qmp-usb3-phy
> - qcom,qcm2290-qmp-usb3-phy
> - qcom,sc7180-qmp-usb3-phy
> - - qcom,sc8180x-qmp-ufs-phy
> - qcom,sc8180x-qmp-usb3-phy
> - - qcom,sc8280xp-qmp-ufs-phy
> - - qcom,sdm845-qmp-ufs-phy
> - qcom,sdm845-qmp-usb3-phy
> - qcom,sdm845-qmp-usb3-uni-phy
> - qcom,sdx55-qmp-usb3-uni-phy
> - qcom,sdx65-qmp-usb3-uni-phy
> - - qcom,sm6115-qmp-ufs-phy
> - - qcom,sm6350-qmp-ufs-phy
> - - qcom,sm8150-qmp-ufs-phy
> - qcom,sm8150-qmp-usb3-phy
> - qcom,sm8150-qmp-usb3-uni-phy
> - - qcom,sm8250-qmp-ufs-phy
> - qcom,sm8250-qmp-usb3-phy
> - qcom,sm8250-qmp-usb3-uni-phy
> - - qcom,sm8350-qmp-ufs-phy
> - qcom,sm8350-qmp-usb3-phy
> - qcom,sm8350-qmp-usb3-uni-phy
> - - qcom,sm8450-qmp-ufs-phy
> - qcom,sm8450-qmp-usb3-phy
>
> reg:
> @@ -202,60 +191,6 @@ allOf:
> required:
> - vdda-phy-supply
> - vdda-pll-supply
> - - if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - qcom,msm8996-qmp-ufs-phy
> - then:
> - properties:
> - clocks:
> - items:
> - - description: 19.2 MHz ref clock.
> - clock-names:
> - items:
> - - const: ref
> - resets:
> - items:
> - - description: PHY reset in the UFS controller.
> - reset-names:
> - items:
> - - const: ufsphy
> - required:
> - - vdda-phy-supply
> - - vdda-pll-supply
> - - if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - qcom,msm8998-qmp-ufs-phy
> - - qcom,sc8180x-qmp-ufs-phy
> - - qcom,sc8280xp-qmp-ufs-phy
> - - qcom,sdm845-qmp-ufs-phy
> - - qcom,sm6350-qmp-ufs-phy
> - - qcom,sm8150-qmp-ufs-phy
> - - qcom,sm8250-qmp-ufs-phy
> - then:
> - properties:
> - clocks:
> - items:
> - - description: 19.2 MHz ref clock.
> - - description: PHY reference aux clock.
> - clock-names:
> - items:
> - - const: ref
> - - const: ref_aux
> - resets:
> - items:
> - - description: PHY reset in the UFS controller.
> - reset-names:
> - items:
> - - const: ufsphy
> - required:
> - - vdda-phy-supply
> - - vdda-pll-supply
> - if:
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml
> new file mode 100644
> index 000000000000..4471f1b4fb7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml
> @@ -0,0 +1,149 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/qcom,qmp-ufs-phy.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
All previous comments apply.
Best regards,
Krzysztof
Powered by blists - more mailing lists