linux-kernel - Re: [PATCH 2/2] serial: RS485 termination is supported if DT provides one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6216fed3-3a68-3de5-5cbf-9c2aebe68727@gmx.de>
Date:   Tue, 5 Jul 2022 12:27:32 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] serial: RS485 termination is supported if DT provides
 one


On 04.07.22 11:45, Ilpo Järvinen wrote:
> When DT provides rs485-term, set termination flag as supported.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/tty/serial/serial_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index a9cf1044a9fa..1db44cde76f6 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -3409,6 +3409,8 @@ int uart_get_rs485_mode(struct uart_port *port)
>  		port->rs485_term_gpio = NULL;
>  		return dev_err_probe(dev, ret, "Cannot get rs485-term-gpios\n");
>  	}
> +	if (port->rs485_term_gpio)
> +		port->rs485_supported.flags |= SER_RS485_TERMINATE_BUS;
>
>  	return 0;
>  }


FWIW:
Reviewed-by: Lino Sanfilippo <l.sanfilippo@...bus.com>


Regards,
Lino