linux-kernel - Re: [PATCH] mips: micro-optimize calculate_cpu_foreign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220705104021.GJ9951@alpha.franken.de>
Date:   Tue, 5 Jul 2022 12:40:21 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Yury Norov <yury.norov@...il.com>
Cc:     Alexander Lobakin <alobakin@...me>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Mao Bibo <maobibo@...ngson.cn>,
        Philippe Mathieu-Daudé <f4bug@...at.org>,
        WANG Xuerui <kernel@...0n.name>, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH] mips: micro-optimize calculate_cpu_foreign_map()

On Thu, Jun 30, 2022 at 07:59:04PM -0700, Yury Norov wrote:
> On Tue, Jun 21, 2022 at 07:47:29AM -0700, Yury Norov wrote:
> > The inner loop in calculate_cpu_foreign_map() walks the whole
> > cpumask to check if we have siblings for a given cpu.
> > 
> > We can just break after a 1st match and avoid useless traversing
> > the rest of mask.
> > 
> > Loongarch has an identical function, so fix it here as well.
> > 
> > Signed-off-by: Yury Norov <yury.norov@...il.com>
> 
> Ping?

as this is touching two different archs, it would have been easier
to send this in two different patches.

Huacai, should I take the patch ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]