linux-kernel - Re: [PATCH 1/2] dt-bindings: i2c: mv64xxx: Add variants with offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220705114209.69193017@donnerap.cambridge.arm.com>
Date:   Tue, 5 Jul 2022 11:42:09 +0100
From:   Andre Przywara <andre.przywara@....com>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Wolfram Sang <wsa@...nel.org>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: mv64xxx: Add variants with
 offload support

On Sat,  2 Jul 2022 00:25:42 -0500
Samuel Holland <samuel@...lland.org> wrote:

Hi,

> V536 and newer Allwinner SoCs contain an updated I2C controller which
> includes an offload engine for master mode. The controller retains the
> existing register interface, so the A31 compatible still applies.
> 
> Add the V536 compatible and use it as a fallback for other SoCs with the
> updated hardware. This includes two SoCs that were already documented
> (H616 and A100) and two new SoCs (R329 and D1).
> 
> Signed-off-by: Samuel Holland <samuel@...lland.org>

That seems correct to me: I couldn't get hold of manuals of some of the new
SoCs, but at least the D1 and H616 indeed add an extra set of registers
for this "TWI driver" offload engine. But the basic operation is still
supported, so the two fallbacks make sense.

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> ---
> 
>  .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml   | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> index f771c09aabfc..0ec033e48830 100644
> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -21,10 +21,18 @@ properties:
>            - enum:
>                - allwinner,sun8i-a23-i2c
>                - allwinner,sun8i-a83t-i2c
> +              - allwinner,sun8i-v536-i2c
>                - allwinner,sun50i-a64-i2c
> -              - allwinner,sun50i-a100-i2c
>                - allwinner,sun50i-h6-i2c
> +          - const: allwinner,sun6i-a31-i2c
> +      - description: Allwinner SoCs with offload support
> +        items:
> +          - enum:
> +              - allwinner,sun20i-d1-i2c
> +              - allwinner,sun50i-a100-i2c
>                - allwinner,sun50i-h616-i2c
> +              - allwinner,sun50i-r329-i2c
> +          - const: allwinner,sun8i-v536-i2c
>            - const: allwinner,sun6i-a31-i2c
>        - const: marvell,mv64xxx-i2c
>        - const: marvell,mv78230-i2c