linux-kernel - Re: [PATCH 09/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add example node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YsQnwyyXcffNlkLT@hovoldconsulting.com>
Date:   Tue, 5 Jul 2022 14:00:03 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add
 example node

On Tue, Jul 05, 2022 at 01:32:30PM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2022 12:22, Johan Hovold wrote:
> > On Tue, Jul 05, 2022 at 12:10:29PM +0200, Krzysztof Kozlowski wrote:
> >> On 05/07/2022 11:42, Johan Hovold wrote:
> >>> Add an example node based on a cleaned up version of msm8996.dtsi.
> >>>
> >>> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> >>
> >> Squash it, please.
> > 
> > Why? It's a new addition to the schema.
> 
> Because it is not really new. When you add new bindings or convert
> existing ones (without example), it is expected that example is within
> that commit. You do here the same - add entirely new file. Old file had
> example and the bindings. You now split some pieces, convert it, so new
> file is also expected to come with the bindings.
> 
> The same as there is no point to make half-TXT-YAML conversion, there is
> no point in half-split of existing bindings. Either this split is
> correct and complete, or it's not a finished commit and we do not commit
> half-commits.

Fair enough, I'll squash the examples in.

Thanks for the quick review.

Johan