linux-kernel - Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220705025734.GD2303286@anxtwsw-Precision-3640-Tower>
Date:   Tue, 5 Jul 2022 10:57:34 +0800
From:   Xin Ji <xji@...logixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        bliang@...logixsemi.com, qwen@...logixsemi.com,
        jli@...logixsemi.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411
 support

Hi heikki, OK. I'll add comment.
Thanks,
Xin

On Tue, Jun 28, 2022 at 01:48:47PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> On Tue, Jun 28, 2022 at 12:48:42PM +0800, Xin Ji wrote:
> > diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
> > new file mode 100644
> > index 000000000000..76e4b5fc0d9e
> > --- /dev/null
> > +++ b/drivers/usb/typec/anx7411.c
> > @@ -0,0 +1,1564 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +
> > +/*
> > + * Copyright(c) 2022, Analogix Semiconductor. All rights reserved.
> > + *
> > + */
> 
> Could you also add a line to that comment that tells what this driver
> is? So something like this:
> 
> /*
>  * Driver for Analogix ANX7411 USB Type-C and PD controller
>  *
>  * Copyright(c) 2022, Analogix Semiconductor. All rights reserved.
>  */
> 
> thanks,
> 
> -- 
> heikki