linux-kernel - Re: [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEsEZjmG8JV6hz4=a=hWLFxeGom6sGs7LSYzTZnoC-M7jQ@mail.gmail.com>
Date:   Tue, 5 Jul 2022 11:14:58 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     "Michael S . Tsirkin" <mst@...hat.com>,
        Zhu Lingshan <lingshan.zhu@...el.com>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        kernel-janitors@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg

On Tue, Jul 5, 2022 at 3:05 AM Colin Ian King <colin.i.king@...il.com> wrote:
>
> The assignment to pointer cfg is duplicated, the second assignment
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Acked-by: Jason Wang <jasowang@...hat.com>

> ---
>  drivers/vdpa/ifcvf/ifcvf_base.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
> index 48c4dadb0c7c..47b94091733c 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.c
> @@ -29,7 +29,6 @@ u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector)
>  {
>         struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
>
> -       cfg = hw->common_cfg;
>         vp_iowrite16(vector,  &cfg->msix_config);
>
>         return vp_ioread16(&cfg->msix_config);
> --
> 2.35.3
>