linux-kernel - Re: [PATCH v8 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e47b853-bb82-8766-8884-3da931c038a2@linaro.org>
Date:   Wed, 6 Jul 2022 17:25:21 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     LABBE Corentin <clabbe@...libre.com>, Rob Herring <robh@...nel.org>
Cc:     john@...anate.com, heiko@...ech.de, p.zabel@...gutronix.de,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, didi.debian@...ow.org,
        herbert@...dor.apana.org.au, sboyd@...nel.org,
        mturquette@...libre.com, linux-rockchip@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v8 25/33] dt-bindings: crypto: rockchip: convert to new
 driver bindings

On 06/07/2022 16:28, LABBE Corentin wrote:
> Le Wed, Jul 06, 2022 at 07:29:04AM -0600, Rob Herring a écrit :
>> On Wed, 06 Jul 2022 09:04:04 +0000, Corentin Labbe wrote:
>>> The latest addition to the rockchip crypto driver need to update the
>>> driver bindings.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
>>> ---
>>>  .../crypto/rockchip,rk3288-crypto.yaml        | 85 +++++++++++++++++--
>>>  1 file changed, 77 insertions(+), 8 deletions(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml: allOf:0:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed:
>> 	[{'const': 'aclk'}, {'const': 'hclk'}, {'const': 'sclk'}, {'const': 'apb_pclk'}] is too long
>> 	[{'const': 'aclk'}, {'const': 'hclk'}, {'const': 'sclk'}, {'const': 'apb_pclk'}] is too short
>> 	False schema does not allow 4
>> 	1 was expected
>> 	4 is greater than the maximum of 2
>> 	4 is greater than the maximum of 3
> 
> Hello
> 
> I upgraded to dt-schema 2022.07 and fail to reproduce all errors.

Visible on older dtschema (2022.6.dev10+gcd64f75fe091), visible on
newest (2022.7).

Exactly the same error.

Best regards,
Krzysztof