linux-kernel - Re: [PATCH 1/2] netfs: release the folio lock and put the folio before retrying

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ce8c30f-8a33-87e7-1bdc-b73d5b933c85@redhat.com>
Date:   Wed, 6 Jul 2022 08:58:40 +0800
From:   Xiubo Li <xiubli@...hat.com>
To:     David Howells <dhowells@...hat.com>,
        Jeff Layton <jlayton@...nel.org>
Cc:     idryomov@...il.com, vshankar@...hat.com,
        linux-kernel@...r.kernel.org, ceph-devel@...r.kernel.org,
        willy@...radead.org, keescook@...omium.org,
        linux-fsdevel@...r.kernel.org, linux-cachefs@...hat.com
Subject: Re: [PATCH 1/2] netfs: release the folio lock and put the folio
 before retrying


On 7/5/22 9:21 PM, David Howells wrote:
> Jeff Layton <jlayton@...nel.org> wrote:
>
>> I don't know here... I think it might be better to just expect that when
>> this function returns an error that the folio has already been unlocked.
>> Doing it this way will mean that you will lock and unlock the folio a
>> second time for no reason.
> I seem to remember there was some reason you wanted the folio unlocking and
> putting.  I guess you need to drop the ref to flush it.
>
> Would it make sense for ->check_write_begin() to be passed a "struct folio
> **folio" rather than "struct folio *folio" and then the filesystem can clear
> *folio if it disposes of the page?

Yeah, this also sounds good to me.

-- Xiubo


> David
>