linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add value property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706162335.2eewgf7l3xghdjtr@pali>
Date:   Wed, 6 Jul 2022 18:23:35 +0200
From:   Pali Rohár <pali@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Pavel Machek <pavel@....cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Behún <kabel@...nel.org>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add value
 property

On Wednesday 06 July 2022 10:21:11 Rob Herring wrote:
> On Wed, Jul 06, 2022 at 01:28:27PM +0200, Pali Rohár wrote:
> > Allow to define inverted logic (0 - enable LED, 1 - disable LED) via value
> > property. This property name is already used by other syscon drivers, e.g.
> > syscon-reboot.
> 
> Yes, but those are potentially multi-bit values. This is a single bit 
> value, and the only value that's ever needed is 0. Why not just use 
> 'active-low' here?

Just because to have uniform definitions across more syscon nodes.

> > 
> > Signed-off-by: Pali Rohár <pali@...nel.org>
> > ---
> >  .../devicetree/bindings/leds/register-bit-led.yaml    | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/register-bit-led.yaml b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> > index 79b8fc0f9d23..d6054a3f9087 100644
> > --- a/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> > +++ b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> > @@ -43,6 +43,17 @@ properties:
> >          0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
> >          0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]
> >  
> > +  value:
> > +    description:
> > +      bit value of ON state for the bit controlling this LED in the register
> > +      when not specified it is same as the mask
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum:
> > +      [ 0x0, 0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80, 0x100, 0x200, 0x400, 0x800,
> > +        0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x20000, 0x40000, 0x80000,
> > +        0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
> > +        0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]
> > +
> >    offset:
> >      description:
> >        register offset to the register controlling this LED
> > -- 
> > 2.20.1
> > 
> >