linux-kernel - Re: [PATCH] bpf/scripts: Generate GCC compatible helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59cf427f-dd37-4784-4bf7-1a655df44dbe@iogearbox.net>
Date:   Wed, 6 Jul 2022 19:12:46 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     James Hilliard <james.hilliard1@...il.com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] bpf/scripts: Generate GCC compatible helpers

On 7/6/22 4:06 PM, James Hilliard wrote:
> The current bpf_helper_defs.h helpers are llvm specific and don't work
> correctly with gcc.
> 
> Generate gcc compatible headers based on the format in bpf-helpers.h.
> 
> See:
> https://github.com/gcc-mirror/gcc/blob/releases/gcc-12.1.0/gcc/config/bpf/bpf-helpers.h#L24-L27
> 
> Signed-off-by: James Hilliard <james.hilliard1@...il.com>

Please improve the commit description a bit with all the necessary context
around this, and perhaps also provide a small before/after extract around
the bpf-helpers.h. The github.com/gcc-mirror could stay as reference but all
details should be self-explanatory in commit description.

Thanks,
Daniel