linux-kernel - Re: [PATCH v2 5/5] iio: pressure: bmp280: Adds more tunable config parameters for BMP380

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ve+jUBW4b7zTEk8M_PpDUdmG3XcTjLt6sU-WpnmWF=YuA@mail.gmail.com>
Date:   Wed, 6 Jul 2022 19:49:04 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Angel Iglesias <ang.iglesiasg@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] iio: pressure: bmp280: Adds more tunable config
 parameters for BMP380

On Wed, Jul 6, 2022 at 4:39 PM Angel Iglesias <ang.iglesiasg@...il.com> wrote:
> On mié, 2022-07-06 at 14:42 +0200, Andy Shevchenko wrote:
> > On Wed, Jul 6, 2022 at 12:51 AM Angel Iglesias <ang.iglesiasg@...il.com>
> > wrote:
> > > On Mon, 2022-07-04 at 22:08 +0200, Andy Shevchenko wrote:
> > > > On Mon, Jul 4, 2022 at 2:41 AM Angel Iglesias <ang.iglesiasg@...il.com>
> > > > wrote:

...

> > > > Why do you need to copy'n'paste dozens of the very same comment?
> > > > Wouldn't it be enough to explain it somewhere at the top of the file
> > > > or in the respective documentation (if it exists)?
> >
> > No answer?
>
> Apologies, I'll fix the duplicated comments. Would be a good place for the
> comment before the function "bmp280_write_raw" or at the start of the switch
> block?

I believe you may find the best place yourself. My point is to see no
duplication, that's it.

-- 
With Best Regards,
Andy Shevchenko