linux-kernel - Re: [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJQVJerfojCku9tmSa1_b2EDkvVgCs+2SvCmjCMe+gfyA@mail.gmail.com>
Date:   Wed, 6 Jul 2022 12:11:31 -0600
From:   Rob Herring <robh@...nel.org>
To:     Vidya Sagar <vidyas@...dia.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod <vkoul@...nel.org>, Krzysztof Wilczynski <kw@...ux.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mikko Perttunen <mperttunen@...dia.com>,
        PCI <linux-pci@...r.kernel.org>, devicetree@...r.kernel.org,
        linux-tegra <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-phy@...ts.infradead.org>,
        Krishna Thota <kthota@...dia.com>,
        Manikanta Maddireddy <mmaddireddy@...dia.com>,
        sagar.tv@...il.com, Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema

On Wed, Jul 6, 2022 at 3:53 AM Vidya Sagar <vidyas@...dia.com> wrote:
>
>
>
> On 7/1/2022 2:34 AM, Rob Herring wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Wed, Jun 29, 2022 at 11:34:26AM +0530, Vidya Sagar wrote:
> >> From: Thierry Reding <treding@...dia.com>
> >>
> >> Convert the Tegra194 PCIe bindings from the free-form text format to
> >> json-schema.
> >>
> >> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> >> Signed-off-by: Thierry Reding <treding@...dia.com>
> >> ---

> >> +  nvidia,bpmp:
> >> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> >> +    description: |
> >> +      Must contain a pair of phandle to BPMP controller node followed by controller ID. Following
> >> +      are the controller IDs for each controller:
> >> +
> >> +        0: C0
> >> +        1: C1
> >> +        2: C2
> >> +        3: C3
> >> +        4: C4
> >> +        5: C5
> >> +    items:
> >> +      - items:
> >> +          - minimum: 0
> >> +            maximum: 0xffffffff
> >
> > That's already the limit. Just a description is fine.
> >
> >> +          - enum: [ 0, 1, 2, 3, 4, 5 ]
> >
> > maximum: 5
>
> Setting the maximum to '5' is resulting in the following error.
>
> pcie-ep@...a0000: nvidia,bpmp:0:0: 4294967295 is greater than the
> maximum of 5
>
> Could you please help me understand why I'm seeing this error?

This is what you need:

items:
  - items:
      - description: phandle to BPMP controller node
      - description: controller ID
        maximum: 5