linux-kernel - Re: [PATCH -next] vdpa/mlx5: Use eth_broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEvGsJbR_vCfGfi_Stxw0kiLwJZMXy6m-YXOkj73Y1WEEQ@mail.gmail.com>
Date:   Wed, 6 Jul 2022 12:04:22 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Xu Qiang <xuqiang36@...wei.com>
Cc:     mst <mst@...hat.com>, Eli Cohen <elic@...dia.com>,
        Si-Wei Liu <si-wei.liu@...cle.com>,
        Parav Pandit <parav@...dia.com>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>, rui.xiang@...wei.com
Subject: Re: [PATCH -next] vdpa/mlx5: Use eth_broadcast_addr() to assign
 broadcast address

On Mon, Jul 4, 2022 at 10:16 AM Xu Qiang <xuqiang36@...wei.com> wrote:
>
> Using eth_broadcast_addr() to assign broadcast address instead
> of memset().
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Xu Qiang <xuqiang36@...wei.com>

Acked-by: Jason Wang <jasowang@...hat.com>

> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index f738c78ef446..3b2929d4a819 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1440,7 +1440,7 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,
>         headers_v = MLX5_ADDR_OF(fte_match_param, spec->match_value, outer_headers);
>         dmac_c = MLX5_ADDR_OF(fte_match_param, headers_c, outer_headers.dmac_47_16);
>         dmac_v = MLX5_ADDR_OF(fte_match_param, headers_v, outer_headers.dmac_47_16);
> -       memset(dmac_c, 0xff, ETH_ALEN);
> +       eth_broadcast_addr(dmac_c);
>         ether_addr_copy(dmac_v, mac);
>         MLX5_SET(fte_match_set_lyr_2_4, headers_c, cvlan_tag, 1);
>         if (tagged) {
> --
> 2.17.1
>