| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3ce00e2e-6fe5-2f7a-8aab-d630a7235d61@amd.com>
Date: Thu, 7 Jul 2022 00:51:25 +0530
From: "Mukunda,Vijendar" <vijendar.mukunda@....com>
To: kernel test robot <lkp@...el.com>
Cc: kbuild-all@...ts.01.org,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>
Subject: Re: [ammarfaizi2-block:broonie/sound/for-next 328/352]
sound/soc/soc-acpi.c:58:36: warning: initialization of 'struct acpi_device *'
from 'int' makes pointer from integer without a cast
On 7/6/22 11:11 PM, kernel test robot wrote:
> tree: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fammarfaizi2%2Flinux-block&data=05%7C01%7CVijendar.Mukunda%40amd.com%7Cef10db08c5534596339908da5f76dfa5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927261404326072%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4nJNUAze7X8XcRNnQMsVjN4fcOxaryEqbHl%2Fxt4EWs8%3D&reserved=0 broonie/sound/for-next
> head: 6abb4d7d17ffe320e9b7e22f474e5631c0464524
> commit: f94fa84058014f81ad526641f1b1f583ca2cf32f [328/352] ASoC: amd: enable machine driver build for Jadeite platform
> config: alpha-allyesconfig (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2F20220707%2F202207070102.kkRe03MS-lkp%40intel.com%2Fconfig&data=05%7C01%7CVijendar.Mukunda%40amd.com%7Cef10db08c5534596339908da5f76dfa5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927261404326072%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xT%2B7AxR7Er7aOpEfVpsZAAyN%2FYjlPQIfiUJnvy%2BCYH4%3D&reserved=0)
> compiler: alpha-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=05%7C01%7CVijendar.Mukunda%40amd.com%7Cef10db08c5534596339908da5f76dfa5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927261404326072%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4wY5Qb%2BnNN9N4dpLqvjmQhjR%2BonqxNSdeI1i733u7wY%3D&reserved=0 -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fammarfaizi2%2Flinux-block%2Fcommit%2Ff94fa84058014f81ad526641f1b1f583ca2cf32f&data=05%7C01%7CVijendar.Mukunda%40amd.com%7Cef10db08c5534596339908da5f76dfa5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927261404326072%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WF9J9A5GimbiqqQiHNsj3InTKUrdQ%2BnzymYIP81bsDo%3D&reserved=0
> git remote add ammarfaizi2-block https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fammarfaizi2%2Flinux-block&data=05%7C01%7CVijendar.Mukunda%40amd.com%7Cef10db08c5534596339908da5f76dfa5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637927261404326072%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4nJNUAze7X8XcRNnQMsVjN4fcOxaryEqbHl%2Fxt4EWs8%3D&reserved=0
> git fetch --no-tags ammarfaizi2-block broonie/sound/for-next
> git checkout f94fa84058014f81ad526641f1b1f583ca2cf32f
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash sound/soc/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
> sound/soc/soc-acpi.c:34:1: error: redefinition of 'snd_soc_acpi_find_machine'
> 34 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
JD platform Machine driver has ACPI dependency. With out ACPI CONFIG
enabled, ACP machine driver shouldn't be compiled.
Will modify the ACPI dependency as "depends on SND_SOC_AMD_ACP && ACPI"
and push the new patch.
-
Vijendar
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/soc/soc-acpi.c:9:
> include/sound/soc-acpi.h:38:1: note: previous definition of 'snd_soc_acpi_find_machine' with type 'struct snd_soc_acpi_mach *(struct snd_soc_acpi_mach *)'
> 38 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c: In function 'snd_soc_acpi_find_package':
> sound/soc/soc-acpi.c:58:36: error: implicit declaration of function 'acpi_fetch_acpi_dev'; did you mean 'device_match_acpi_dev'? [-Werror=implicit-function-declaration]
> 58 | struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
> | ^~~~~~~~~~~~~~~~~~~
> | device_match_acpi_dev
>>> sound/soc/soc-acpi.c:58:36: warning: initialization of 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> sound/soc/soc-acpi.c:64:25: error: invalid use of undefined type 'struct acpi_device'
> 64 | if (adev && adev->status.present && adev->status.functional) {
> | ^~
> sound/soc/soc-acpi.c:64:49: error: invalid use of undefined type 'struct acpi_device'
> 64 | if (adev && adev->status.present && adev->status.functional) {
> | ^~
> sound/soc/soc-acpi.c:80:26: error: implicit declaration of function 'acpi_extract_package' [-Werror=implicit-function-declaration]
> 80 | status = acpi_extract_package(myobj,
> | ^~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c: At top level:
> sound/soc/soc-acpi.c:95:6: error: redefinition of 'snd_soc_acpi_find_package_from_hid'
> 95 | bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/soc/soc-acpi.c:9:
> include/sound/soc-acpi.h:44:1: note: previous definition of 'snd_soc_acpi_find_package_from_hid' with type 'bool(const u8 *, struct snd_soc_acpi_package_context *)' {aka '_Bool(const unsigned char *, struct snd_soc_acpi_package_context *)'}
> 44 | snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c:109:27: error: redefinition of 'snd_soc_acpi_codec_list'
> 109 | struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/soc/soc-acpi.c:9:
> include/sound/soc-acpi.h:51:41: note: previous definition of 'snd_soc_acpi_codec_list' with type 'struct snd_soc_acpi_mach *(void *)'
> 51 | static inline struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
>
> vim +58 sound/soc/soc-acpi.c
>
> 8ceffd229f0ef1 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2016-02-08 54
> 7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 55 static acpi_status snd_soc_acpi_find_package(acpi_handle handle, u32 level,
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 56 void *context, void **ret)
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 57 {
> ff4865b3c8cd74 sound/soc/soc-acpi.c Rafael J. Wysocki 2022-01-26 @58 struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
> 59ce3233a538fc sound/soc/soc-acpi.c Pierre-Louis Bossart 2021-04-16 59 acpi_status status;
> 7feb2f786a46d3 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12 60 struct snd_soc_acpi_package_context *pkg_ctx = context;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 61
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 62 pkg_ctx->data_valid = false;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 63
> ff4865b3c8cd74 sound/soc/soc-acpi.c Rafael J. Wysocki 2022-01-26 64 if (adev && adev->status.present && adev->status.functional) {
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 65 struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 66 union acpi_object *myobj = NULL;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 67
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 68 status = acpi_evaluate_object_typed(handle, pkg_ctx->name,
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 69 NULL, &buffer,
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 70 ACPI_TYPE_PACKAGE);
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 71 if (ACPI_FAILURE(status))
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 72 return AE_OK;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 73
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 74 myobj = buffer.pointer;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 75 if (!myobj || myobj->package.count != pkg_ctx->length) {
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 76 kfree(buffer.pointer);
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 77 return AE_OK;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 78 }
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 79
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 80 status = acpi_extract_package(myobj,
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 81 pkg_ctx->format, pkg_ctx->state);
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 82 if (ACPI_FAILURE(status)) {
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 83 kfree(buffer.pointer);
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 84 return AE_OK;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 85 }
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 86
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 87 kfree(buffer.pointer);
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 88 pkg_ctx->data_valid = true;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 89 return AE_CTRL_TERMINATE;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 90 }
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 91
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 92 return AE_OK;
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 93 }
> 3421894765a345 sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12 94
>
> :::::: The code at line 58 was first introduced by commit
> :::::: ff4865b3c8cd746ef72f59bdd485848b4cebd43d ALSA: Replace acpi_bus_get_device()
>
> :::::: TO: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> :::::: CC: Takashi Iwai <tiwai@...e.de>
>
Powered by blists - more mailing lists