lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Jul 2022 12:30:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 08/13] USB: mtu3: tracing: Use the new __vstring() helper

Hi Steven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on wireless-next/main]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-events-Add-__vstring-and-__assign_vstr-helpers/20220706-065125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: arm64-randconfig-r005-20220703
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f553287b588916de09c66e3e32bf75e5060f967f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/829b320ff9db68465d88e10181df019fffb775db
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Steven-Rostedt/tracing-events-Add-__vstring-and-__assign_vstr-helpers/20220706-065125
        git checkout 829b320ff9db68465d88e10181df019fffb775db
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/usb/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:94:
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: type name requires a specifier or qualifier
                   __vstring(msg, vaf->fmt, vaf->va),
                                                    ^
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: expected member name or ';' after declaration specifiers
   drivers/usb/mtu3/./mtu3_trace.h:23:1: error: expected member name or ';' after declaration specifiers
   TRACE_EVENT(mtu3_log,
   ^
   include/trace/trace_events.h:40:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_EVENT_CLASS(name,                              \
           ^
   include/trace/trace_events.h:55:3: note: expanded from macro 'DECLARE_EVENT_CLASS'
                   char                    __data[];                       \
                   ^
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:94:
>> drivers/usb/mtu3/./mtu3_trace.h:23:1: error: expected ';' at end of declaration list
   include/trace/trace_events.h:40:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_EVENT_CLASS(name,                              \
           ^
   include/trace/trace_events.h:55:3: note: expanded from macro 'DECLARE_EVENT_CLASS'
                   char                    __data[];                       \
                   ^
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:132:
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: type name requires a specifier or qualifier
                   __vstring(msg, vaf->fmt, vaf->va),
                                                    ^
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: expected member name or ';' after declaration specifiers
   drivers/usb/mtu3/./mtu3_trace.h:23:1: error: expected member name or ';' after declaration specifiers
   TRACE_EVENT(mtu3_log,
   ^
   include/trace/trace_events.h:40:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_EVENT_CLASS(name,                              \
           ^
   include/trace/trace_events.h:117:10: note: expanded from macro 'DECLARE_EVENT_CLASS'
                   tstruct;                                                \
                          ^
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:250:
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: expected expression
                   __vstring(msg, vaf->fmt, vaf->va),
                                                    ^
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:268:
>> drivers/usb/mtu3/./mtu3_trace.h:27:3: error: no member named '__data' in 'trace_event_raw_mtu3_log'
                   __string(name, dev_name(dev))
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/stages/stage5_get_offsets.h:36:29: note: expanded from macro '__string'
   #define __string(item, src) __dynamic_array(char, item,                 \
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/stages/stage5_get_offsets.h:31:11: note: expanded from macro '__dynamic_array'
                                  offsetof(typeof(*entry), __data);        \
                                  ^                        ~~~~~~
   include/linux/stddef.h:16:32: note: expanded from macro 'offsetof'
   #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
                                   ^                        ~~~~~~
   note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/trace/trace_events.h:43:16: note: expanded from macro 'TRACE_EVENT'
                                PARAMS(tstruct),                  \
                                       ^~~~~~~
   include/linux/tracepoint.h:107:25: note: expanded from macro 'PARAMS'
   #define PARAMS(args...) args
                           ^~~~
   include/trace/trace_events.h:263:2: note: expanded from macro 'DECLARE_EVENT_CLASS'
           tstruct;                                                        \
           ^~~~~~~
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:268:
   drivers/usb/mtu3/./mtu3_trace.h:28:3: error: no member named '__data' in 'trace_event_raw_mtu3_log'
                   __vstring(msg, vaf->fmt, vaf->va),
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/stages/stage5_get_offsets.h:43:34: note: expanded from macro '__vstring'
   #define __vstring(item, fmt, ap) __dynamic_array(char, item,            \
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/stages/stage5_get_offsets.h:31:11: note: expanded from macro '__dynamic_array'
                                  offsetof(typeof(*entry), __data);        \
                                  ^                        ~~~~~~
   include/linux/stddef.h:16:32: note: expanded from macro 'offsetof'
   #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
                                   ^                        ~~~~~~
   note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/trace/trace_events.h:43:16: note: expanded from macro 'TRACE_EVENT'
                                PARAMS(tstruct),                  \
                                       ^~~~~~~
   include/linux/tracepoint.h:107:25: note: expanded from macro 'PARAMS'
   #define PARAMS(args...) args
                           ^~~~
   include/trace/trace_events.h:263:2: note: expanded from macro 'DECLARE_EVENT_CLASS'
           tstruct;                                                        \
           ^~~~~~~
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:268:
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: expected expression
                   __vstring(msg, vaf->fmt, vaf->va),
                                                    ^
   drivers/usb/mtu3/./mtu3_trace.h:23:1: error: expected expression
   TRACE_EVENT(mtu3_log,
   ^
   include/trace/trace_events.h:40:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_EVENT_CLASS(name,                              \
           ^
   include/trace/trace_events.h:263:9: note: expanded from macro 'DECLARE_EVENT_CLASS'
           tstruct;                                                        \
                  ^
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:419:
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: expected expression
                   __vstring(msg, vaf->fmt, vaf->va),
                                                    ^
   In file included from drivers/usb/mtu3/mtu3_trace.c:12:
   In file included from drivers/usb/mtu3/./mtu3_trace.h:279:
   In file included from include/trace/define_trace.h:103:
   In file included from include/trace/perf.h:113:
>> drivers/usb/mtu3/./mtu3_trace.h:28:36: error: expected expression
                   __vstring(msg, vaf->fmt, vaf->va),
                                                    ^
   14 errors generated.


vim +28 drivers/usb/mtu3/./mtu3_trace.h

    22	
  > 23	TRACE_EVENT(mtu3_log,
    24		TP_PROTO(struct device *dev, struct va_format *vaf),
    25		TP_ARGS(dev, vaf),
    26		TP_STRUCT__entry(
  > 27			__string(name, dev_name(dev))
  > 28			__vstring(msg, vaf->fmt, vaf->va),
    29		),
    30		TP_fast_assign(
    31			__assign_str(name, dev_name(dev));
    32			__assign_vstr(msg, vaf->fmt, vaf->va);
    33		),
    34		TP_printk("%s: %s", __get_str(name), __get_str(msg))
    35	);
    36	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (207108 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ