linux-kernel - Re: [PATCH] drm/i915/gem: Really move i915_gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 00:34:08 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     Andi Shyti <andi.shyti@...ux.intel.com>
Cc:     Intel GFX <intel-gfx@...ts.freedesktop.org>,
        DRI Devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Stable <stable@...r.kernel.org>,
        Mark Janes <mark.janes@...el.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        Chris Wilson <chris.p.wilson@...ux.intel.com>,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH] drm/i915/gem: Really move i915_gem_context.link under
 ref protection

Hi,

[...]

> @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
>  	struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
>  						    release_work);
>  	struct i915_address_space *vm;
> +	unsigned long flags;
>  
>  	trace_i915_context_free(ctx);
>  	GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
>  
> +	spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
> +	list_del(&ctx->link);
> +	spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> +

yah! this can't work from a worker.

Andi