linux-kernel - Re: [PATCHv4 3/8] mm: Pass down mm_struct to untagged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 02:13:49 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        Kostya Serebryany <kcc@...gle.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        "H . J . Lu" <hjl.tools@...il.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv4 3/8] mm: Pass down mm_struct to untagged_addr()

On Tue, Jul 05, 2022 at 05:42:21PM +0200, Alexander Potapenko wrote:
> Kirill,
> 
> 
> > diff --git a/lib/strnlen_user.c b/lib/strnlen_user.c
> > index feeb935a2299..abc096a68f05 100644
> > --- a/lib/strnlen_user.c
> > +++ b/lib/strnlen_user.c
> > @@ -97,7 +97,7 @@ long strnlen_user(const char __user *str, long count)
> >                 return 0;
> >
> >         max_addr = TASK_SIZE_MAX;
> > -       src_addr = (unsigned long)untagged_addr(str);
> > +       src_addr = (unsigned long)untagged_addr(current->mm, str);
> 
> In a downstream kernel with LAM disabled I'm seeing current->mm being
> NULL at this point, because strnlen_user() is being called by
> kdevtmpfs.
> IIUC current->mm is only guaranteed to be non-NULL in the userspace
> process context, whereas untagged_addr() may get called in random
> places.
> 
> Am I missing something?

Hm. Could you show a traceback?

As strnlen_user() intended to be used on an user string I expected it to
be called from a process context. I guess I'm wrong, but I don't yet
understand why.

-- 
 Kirill A. Shutemov