linux-kernel - Re: [PATCH] riscv: arch-topology: fix default topology reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202207070728.MiQn5fv0-lkp@intel.com>
Date:   Thu, 7 Jul 2022 07:38:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Conor Dooley <mail@...chuod.ie>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Sudeep Holla <sudeep.holla@....com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Niklas Cassel <niklas.cassel@....com>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Zong Li <zong.li@...ive.com>,
        Emil Renner Berthing <kernel@...il.dk>,
        Jonas Hahnfeld <hahnjo@...njo.de>, Guo Ren <guoren@...nel.org>,
        Anup Patel <anup@...infault.org>,
        Atish Patra <atishp@...shpatra.org>,
        Changbin Du <changbin.du@...el.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Philipp Tomsich <philipp.tomsich@...ll.eu>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Brice Goglin <Brice.Goglin@...ia.fr>
Subject: Re: [PATCH] riscv: arch-topology: fix default topology reporting

Hi Conor,

I love your patch! Yet something to improve:

[auto build test ERROR on b6f1f2fa2bddd69ff46a190b8120bd440fd50563]

url:    https://github.com/intel-lab-lkp/linux/commits/Conor-Dooley/riscv-arch-topology-fix-default-topology-reporting/20220707-024856
base:   b6f1f2fa2bddd69ff46a190b8120bd440fd50563
config: riscv-randconfig-r042-20220706 (https://download.01.org/0day-ci/archive/20220707/202207070728.MiQn5fv0-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f553287b588916de09c66e3e32bf75e5060f967f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/824f4c3cb56ada865e6e3b14457c0582fa255cbf
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Conor-Dooley/riscv-arch-topology-fix-default-topology-reporting/20220707-024856
        git checkout 824f4c3cb56ada865e6e3b14457c0582fa255cbf
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/riscv/kernel/topology.c:17:37: error: use of undeclared identifier 'cpu_topology'
           struct cpu_topology *cpuid_topo = &cpu_topology[cpuid];
                                              ^
>> arch/riscv/kernel/topology.c:31:2: error: call to undeclared function 'update_siblings_masks'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           update_siblings_masks(cpuid);
           ^
   2 errors generated.


vim +/cpu_topology +17 arch/riscv/kernel/topology.c

    14	
    15	void store_cpu_topology(unsigned int cpuid)
    16	{
  > 17		struct cpu_topology *cpuid_topo = &cpu_topology[cpuid];
    18	
    19		if (cpuid_topo->package_id != -1)
    20			goto topology_populated;
    21	
    22		cpuid_topo->thread_id = -1;
    23		cpuid_topo->core_id = cpuid;
    24		cpuid_topo->package_id = cpu_to_node(cpuid);
    25	
    26		pr_debug("CPU%u: package %d core %d thread %d\n",
    27			 cpuid, cpuid_topo->package_id, cpuid_topo->core_id,
    28			 cpuid_topo->thread_id);
    29	
    30	topology_populated:
  > 31		update_siblings_masks(cpuid);

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp