linux-kernel - Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706052217epcms2p444cc8608b21d483a66a43ecf4f2140d4@epcms2p4>
Date:   Wed, 06 Jul 2022 14:22:17 +0900
From:   Wangseok Lee <wangseok.lee@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "kishon@...com" <kishon@...com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jesper.nilsson@...s.com" <jesper.nilsson@...s.com>,
        "lars.persson@...s.com" <lars.persson@...s.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "kw@...ux.com" <kw@...ux.com>,
        "linux-arm-kernel@...s.com" <linux-arm-kernel@...s.com>,
        "kernel@...s.com" <kernel@...s.com>
CC:     Moon-Ki Jun <moonki.jun@...sung.com>,
        Sang Min Kim <hypmean.kim@...sung.com>,
        Dongjin Yang <dj76.yang@...sung.com>,
        Yeeun Kim <yeeun119.kim@...sung.com>
Subject: Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy

On 05/07/2022 19:59, Krzysztof Kozlowski wrote:
> On 29/06/2022 09:18, Wangseok Lee wrote:
>> Just a gentle ping for this patch, if any concern on this patch please let me know.
>> 
> 
> You received comments to fix in this patch. Exactly four. Four important
> points to fix. Therefore what is this ping about?
> 
> Without fixing these items, your patch cannot be accepted. What is more
> to ping here?
> 
> Best regards,
> Krzysztof

I tried to receive your opinion about the fix point .
I will request a review again after modifying it in the next patch.

Thank you.

>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: PCIe PHY reference clock
> 
> refer to sample-schema.yaml, even if the clock item is single,
> it seems to be used as follows.
> 
> clocks:
>   maxItems: 1
> 
> clock-names:
>   items:
>     - const: ref
> 
> If only "clocks:" are define and clock-names are not define,
> the following warning occurs.
> "'clock-names' does not match any of the regexes"
> 
>>> +
>>> +  lcpll-ref-clk:
>>> +    const: 1
>> 
>> Unknown field... custom properties need vendor (axis,), type (boolean)
>> and description.
>> 
> 
> "lcpl-ref-clk" has an enum type value, so i will modify it as below.
> 
> 
> axis,lcpll-ref-clk:
>   description:
>     select the reference clock of phy and initialization is performed
>     with the reference clock according to the selected value.
>   $ref: /schemas/types.yaml#/definitions/uint32
>   enum: [ 0, 1, 2, 3, 4 ]
>