linux-kernel - Re: [PATCH] dmaengine: lgm: Fix an error handling path in intel_ldma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YsUcVXhGvLVb7VOa@matsya>
Date:   Wed, 6 Jul 2022 10:53:33 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH] dmaengine: lgm: Fix an error handling path in
 intel_ldma_probe()

On 22-05-22, 19:41, Christophe JAILLET wrote:
> ldma_clk_disable() calls both:
> 	clk_disable_unprepare(d->core_clk);
> 	reset_control_assert(d->rst);
> 
> So, should devm_reset_control_get_optional() fail, core_clk should not
> be prepare_enable'd before it, otherwise it will never be
> disable_unprepare'd.
> 
> Reorder the code to handle the error handling path as expected.

Applied, thanks

-- 
~Vinod