linux-kernel - Re: [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused vddp-ref-clk supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YsUlob0Cj9WmDzcF@hovoldconsulting.com>
Date:   Wed, 6 Jul 2022 08:03:13 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused
 vddp-ref-clk supply

On Tue, Jul 05, 2022 at 08:13:55PM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2022 14:43, Johan Hovold wrote:

> > So you suggest we keep this regulator for all PHY variants even though
> > it was probably only needed for UFS on some older SoCs?
> 
> No. I commented only that reason is not a good one. The proper reason
> could be: there is or there is no such pin in the device or the history
> tells that adding it for all variants was a mistake.

Ok, I'll include it since it was there as an optional regulator from the
start and hence implicitly made part of the binding for later PHYs even
though it likely only applies to the older MSM8996/98.

If anyone has access to the documentation they can drop it later.

Johan