linux-kernel - Re: [PATCH] KVM: arm64: Don't return from void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165709805020.885966.4815879973915586287.b4-ty@kernel.org>
Date:   Wed,  6 Jul 2022 10:00:58 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     kvmarm@...ts.cs.columbia.edu, Will Deacon <will@...nel.org>,
        Alexandru Elisei <alexandru.elisei@....com>,
        Oliver Upton <oliver.upton@...ux.dev>,
        linux-arm-kernel@...ts.infradead.org,
        Catalin Marinas <catalin.marinas@....com>,
        linux-kernel@...r.kernel.org, Quentin Perret <qperret@...gle.com>,
        James Morse <james.morse@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>
Cc:     kernel-team@...roid.com
Subject: Re: [PATCH] KVM: arm64: Don't return from void function

On Tue, 5 Jul 2022 14:23:10 +0000, Quentin Perret wrote:
> Although harmless, the return statement in kvm_unexpected_el2_exception
> is rather confusing as the function itself has a void return type. The
> C standard is also pretty clear that "A return statement with an
> expression shall not appear in a function whose return type is void".
> Given that this return statement does not seem to add any actual value,
> let's not pointlessly violate the standard.
> 
> [...]

Applied to kvm-arm64/misc-5.20, thanks!

[1/1] KVM: arm64: Don't return from void function
      commit: 1c3ace2b8b3995d3213c5e2d2aca01a0577a3b0f

Cheers,

	M.
-- 
Marc Zyngier <maz@...nel.org>