linux-kernel - Re: [PATCH 1/2] [V1,1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SG2PR03MB5006AB4C7E356CE321F628D9CC809@SG2PR03MB5006.apcprd03.prod.outlook.com>
Date:   Wed,  6 Jul 2022 17:36:20 +0800
From:   Jimmy Chen <jinghung.chen3@...mail.com>
To:     krzysztof.kozlowski@...aro.org
Cc:     agross@...nel.org, alan-huang@...nta.corp-partner.google.com,
        bjorn.andersson@...aro.org, devicetree@...r.kernel.org,
        dianders@...omium.org, jinghung.chen3@...mail.com,
        konrad.dybcio@...ainline.org, krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org
Subject: Re: [PATCH 1/2] [V1,1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family

To keep the consistency of the format for Chromebook items,
we basically add these items based on the rules discussed in the previous patch series here
https://lore.kernel.org/all/20220520143502.v4.1.I71e42c6174f1cec17da3024c9f73ba373263b9b6@changeid/.

We are little configured with “one entry - one enum “. Do you mean something like below example?
We suggest keep items separated as it is more readable.

      - description: Google Villager
        items:
          - const: google,villager-rev0
          - const: google,villager
          - const: google,villager-rev0-sku0
          - const: google,villager-sku0
          - const: qcom,sc7280

Best regards,
Jimmy Chen