linux-kernel - Re: [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2829e71b-1769-ce24-f810-d63e619aa5f0@linaro.org>
Date:   Wed, 6 Jul 2022 12:06:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Vidya Sagar <vidyas@...dia.com>, Rob Herring <robh@...nel.org>
Cc:     bhelgaas@...gle.com, lorenzo.pieralisi@....com,
        thierry.reding@...il.com, jonathanh@...dia.com, kishon@...com,
        vkoul@...nel.org, kw@...ux.com, p.zabel@...gutronix.de,
        mperttunen@...dia.com, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
        kthota@...dia.com, mmaddireddy@...dia.com, sagar.tv@...il.com,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema

On 06/07/2022 11:53, Vidya Sagar wrote:
>>> +  nvidia,bpmp:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +    description: |
>>> +      Must contain a pair of phandle to BPMP controller node followed by controller ID. Following
>>> +      are the controller IDs for each controller:
>>> +
>>> +        0: C0
>>> +        1: C1
>>> +        2: C2
>>> +        3: C3
>>> +        4: C4
>>> +        5: C5
>>> +    items:
>>> +      - items:
>>> +          - minimum: 0
>>> +            maximum: 0xffffffff
>>
>> That's already the limit. Just a description is fine.
>>
>>> +          - enum: [ 0, 1, 2, 3, 4, 5 ]
>>
>> maximum: 5
> 
> Setting the maximum to '5' is resulting in the following error.
> 
> pcie-ep@...a0000: nvidia,bpmp:0:0: 4294967295 is greater than the 
> maximum of 5
> 
> Could you please help me understand why I'm seeing this error?

Trim your replies.

Why adding minimum:5 to the phandle? Rob said add a description. Nothing
about minimum.

Best regards,
Krzysztof