linux-kernel - Re: [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b2ac34b-7da4-9714-eb65-d62f900c6679@microchip.com>
Date:   Wed, 6 Jul 2022 10:50:44 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <wsa@...nel.org>, <Conor.Dooley@...rochip.com>,
        <linux-i2c@...r.kernel.org>, <ben.dooks@...ethink.co.uk>,
        <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        <Daire.McNamara@...rochip.com>
Subject: Re: [PATCH v6 1/2] i2c: add support for microchip fpga i2c
 controllers



On 06/07/2022 11:32, Wolfram Sang wrote:
> Where are the bindings? Are they already on the way upstream?

Already upstream.
Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml

> 
>> I'd prefer the latter. Being called "core" is unfortunate and I
>> did think about that. i2c-microchip-corei2c would have been my
>> first choice but I thought the double usage of i2c would've been
>> disapproved of haha
> 
> :) Well, double "i2c" is not exactly pretty but since it is the name of
> that IP core...

Yeah, and it is the name of /all/ the IP cores we have (:

> 
>>>> +		if (idev->msg_len <= 0)
>>>> +			finished = true;
>>>
>>> How can it happen that len is < 0? Wouldn't that be an error case?
> 
> Is it to be on the safe side?

Ahh sorry, I missed that. msg_len is a u16 so cannot be <0
I'll change it.

> 
>>> Have you testes SMBUS_QUICK as well?
>>
>> Not specifically SMBUS_QUICK, but I did test with hardware
>> that uses "zero-length" messages.
> 
> Good!
> 
>> Thanks for the review :)
> 
> You are welcome.
>