linux-kernel - Re: [PATCH] gpio: pxa: schedule a devm action for the clock struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve3sPhFOZhL=_2p+1avuo96CP995KD+bi+Pn3gyj1F9TA@mail.gmail.com>
Date:   Wed, 6 Jul 2022 13:48:26 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Stephen Boyd <swboyd@...omium.org>
Cc:     Robert Jarzmik <robert.jarzmik@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>,
        "Signed-off-by : Yuan Can" <yuancan@...wei.com>
Subject: Re: [PATCH] gpio: pxa: schedule a devm action for the clock struct

On Tue, Jul 5, 2022 at 7:29 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> The clock is never released after probe(). Schedule devm actions for
> putting and disabling the clock.

...

> Reported-by: Signed-off-by: Yuan Can <yuancan@...wei.com>

Me puzzled.


...

> +       ret = devm_add_action_or_reset(&pdev->dev, pxa_gpio_clk_put, clk);
> +       if (ret)
> +               return ret;
> +
>         ret = clk_prepare_enable(clk);
> +       if (ret)
> +               return ret;
> +
> +       ret = devm_add_action_or_reset(&pdev->dev,
> +                                      pxa_gpio_clk_disable_unprepare, clk);
> +       if (ret)
>                 return ret;

Can we use recently introduced clk APIs for that? Maybe Stephen has an
immutable branch you may reuse?

-- 
With Best Regards,
Andy Shevchenko