| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 06 Jul 2022 14:37:49 +0200
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: Hans de Goede <hdegoede@...hat.com>,
Linux ACPI <linux-acpi@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [RFC][PATCH] ACPI: EC: Make evaluate acpi_ec_add() _REG for EC operation regions
From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
acpi_ec_ecdt_probe() is called between acpi_load_tables() and
acpi_enable_subsystem(). It passes ACPI_ROOT_OBJECT as ec->handle
to acpi_ec_setup() and so ACPI_ROOT_OBJECT is passed to
acpi_install_address_space_handler() via ec_install_handlers().
Next, acpi_ns_validate_handle() converts it to acpi_gbl_root_node
which is passed to acpi_ev_install_space_handler() and the handler is
installed for acpi_gbl_root_node.
Now, acpi_gbl_root_node is passed to acpi_ev_execute_reg_methods() which
evaluates _REG for any ACPI_ADR_SPACE_EC regions it can find in the
namespace which should not be necessary, because the OS is expected to
make the ECDT operation regions available before evaluating any AML, so
in particular AML is not expected to check the evaluation of _REG before
it accesses these operation regions (see ACPI 6.4, Section 6.5.4,
exception 2 [1]). Doing that is also problematic, because the _REG
methods for the ACPI_ADR_SPACE_EC regions may depend on various _INI, so
they should be be evaluated before running acpi_initialize_objects() [2].
Address this problem by modifying acpi_install_address_space_handler()
to avoid evaluating _REG for ACPI_ADR_SPACE_EC regions when the handler
is installed for acpi_gbl_root_node which indicates the ECDT case.
However, this needs to be accompanied by an EC driver change to
actually trigger the evaluation of _REG for the ACPI_ADR_SPACE_EC
regions when it finds the EC object in the namespace.
Link: https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuration.html#reg-region # [1]
Link: https://github.com/acpica/acpica/pull/786 # [2]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
---
Note: This change doesn't make any practical difference on any of the systems
in my office.
---
drivers/acpi/acpica/evxfregn.c | 12 ++++++++++++
drivers/acpi/ec.c | 7 +++++++
2 files changed, 19 insertions(+)
Index: linux-pm/drivers/acpi/ec.c
===================================================================
--- linux-pm.orig/drivers/acpi/ec.c
+++ linux-pm/drivers/acpi/ec.c
@@ -1632,6 +1632,13 @@ static int acpi_ec_add(struct acpi_devic
acpi_handle_debug(ec->handle, "duplicated.\n");
acpi_ec_free(ec);
ec = boot_ec;
+ /*
+ * Uninstall the EC address space handler and let
+ * acpi_ec_setup() install it again along with
+ * evaluating _REG methogs associated with
+ * ACPI_ADR_SPACE_EC operation regions.
+ */
+ ec_remove_handlers(ec);
}
}
Index: linux-pm/drivers/acpi/acpica/evxfregn.c
===================================================================
--- linux-pm.orig/drivers/acpi/acpica/evxfregn.c
+++ linux-pm/drivers/acpi/acpica/evxfregn.c
@@ -78,6 +78,18 @@ acpi_install_address_space_handler(acpi_
goto unlock_and_exit;
}
+ /*
+ * Avoid evaluating _REG methods if an EC address space handler is
+ * installed for acpi_gbl_root_node, because this is done in order to
+ * make Embedded Controller operation regions, accessed via the Embedded
+ * Controllers described in ECDT, available early (see ACPI 6.4, Section
+ * 6.5.4, exception 2).
+ */
+
+ if (node == acpi_gbl_root_node || space_id == ACPI_ADR_SPACE_EC) {
+ goto unlock_and_exit;
+ }
+
/* Run all _REG methods for this address space */
acpi_ev_execute_reg_methods(node, space_id, ACPI_REG_CONNECT);
Powered by blists - more mailing lists