linux-kernel - Re: [PATCH 0/5] RISC-V: Add cpu-map topology information nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706140011.oow6pswbyct6cwrd@bogus>
Date:   Wed, 6 Jul 2022 15:00:11 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Conor.Dooley@...rochip.com
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, Daire.McNamara@...rochip.com,
        niklas.cassel@....com, damien.lemoal@...nsource.wdc.com,
        geert@...ux-m68k.org, zong.li@...ive.com, kernel@...il.dk,
        hahnjo@...njo.de, devicetree@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Brice.Goglin@...ia.fr
Subject: Re: [PATCH 0/5] RISC-V: Add cpu-map topology information nodes

On Wed, Jul 06, 2022 at 01:04:24PM +0000, Conor.Dooley@...rochip.com wrote:
> On 06/07/2022 10:21, Sudeep Holla wrote:

[...]

> > Looks good. Again package id is not cluster. This is what my series is
> > addressing. So update the log as Package instead of Cluster above. The
> > cluster id will be -1 unless you can get that for DT.
> >
> 
> FYI I took that directly from arm64:
> arch/arm64/kernel/topology.c:L57 (next-20220706)
> 
> 	pr_debug("CPU%u: cluster %d core %d thread %d mpidr %#016llx\n",
> 		 cpuid, cpuid_topo->package_id, cpuid_topo->core_id,
> 		 cpuid_topo->thread_id, mpidr);
> 

Yikes, that needs to change. I will get that updates. Thanks for pointing
that out.

-- 
Regards,
Sudeep