linux-kernel - Re: [PATCH] maple_tree: Fix use of node for global range in mas_wr_spanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706140814.hjf5d2hbfupd6kyp@revolver>
Date:   Wed, 6 Jul 2022 14:08:20 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Yu Zhao <yuzhao@...gle.com>
Subject: Re: [PATCH] maple_tree: Fix use of node for global range in
 mas_wr_spanning_store()

* Andrew Morton <akpm@...ux-foundation.org> [220705 22:55]:
> On Wed, 6 Jul 2022 02:05:37 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:
> 
> > When writing a range with a NULL which expands to 0 - ULONG_MAX, don't
> > use a node to store this value.  Instead, call mas_new_root() which will
> > set the tree pointer to NULL and free all the nodes.
> > 
> > Fix a comment for the allocations in mas_wr_spanning_store().
> > 
> > Add mas_node_count_gfp() and use it to clean up mas_preallocate().
> > 
> > Clean up mas_preallocate() and ensure the ma_state is safe on return.
> > 
> > Update maple_tree.h to set alloc = NULL.
> 
> Cool.
> 
> How are we looking now?  Any known issues still being worked on?

Did you pick up "Subject: [PATCH] mm/mmap: Fix copy_vma() new_vma
check"?  I sent that yesterday as well.

I think we are in good shape.  There were two outstanding issues I had
and this patch plus the copy_vma() patch fixes both.