linux-kernel - Re: [PATCH] net: ag71xx: switch to napi_build_skb() to reuse skbuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jul 2022 19:52:13 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sieng-Piaw Liew <liew.s.piaw@...il.com>
Cc:     chris.snook@...il.com, davem@...emloft.net, edumazet@...gle.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ag71xx: switch to napi_build_skb() to reuse
 skbuff_heads

On Tue,  5 Jul 2022 08:44:34 +0800 Sieng-Piaw Liew wrote:
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -825,7 +825,7 @@ static int ag71xx_tx_packets(struct ag71xx *ag, bool flush)
>  		if (!skb)
>  			continue;
>  
> -		dev_kfree_skb_any(skb);
> +		napi_consume_skb(skb, !flush);

!flush is not sufficient here, napi can be called with a budget of 0.