linux-kernel - Re: [PATCH v4 3/3] clk: qcom: lcc-ipq806x: convert to parent data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 8 Jul 2022 01:35:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christian Marangi <ansuelsmth@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Christian Marangi <ansuelsmth@...il.com>
Subject: Re: [PATCH v4 3/3] clk: qcom: lcc-ipq806x: convert to parent data

Hi Christian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/dt-bindings-clock-add-pcm-reset-for-ipq806x-lcc/20220707-181546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: nios2-randconfig-r003-20220707 (https://download.01.org/0day-ci/archive/20220708/202207080145.UiRhIFg5-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/81953f04f08f730affa53b4637cc05f97da50a1d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christian-Marangi/dt-bindings-clock-add-pcm-reset-for-ipq806x-lcc/20220707-181546
        git checkout 81953f04f08f730affa53b4637cc05f97da50a1d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/clk/qcom/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/clk/qcom/lcc-ipq806x.c:38:25: warning: braces around scalar initializer
      38 |                         { .fw_name = "pxo", .name = "pxo_board" },
         |                         ^
   drivers/clk/qcom/lcc-ipq806x.c:38:25: note: (near initialization for '(anonymous)[0]')
   drivers/clk/qcom/lcc-ipq806x.c:38:27: error: field name not in record or union initializer
      38 |                         { .fw_name = "pxo", .name = "pxo_board" },
         |                           ^
   drivers/clk/qcom/lcc-ipq806x.c:38:27: note: (near initialization for '(anonymous)[0]')
   drivers/clk/qcom/lcc-ipq806x.c:38:38: error: initialization of 'const struct clk_parent_data *' from incompatible pointer type 'char *' [-Werror=incompatible-pointer-types]
      38 |                         { .fw_name = "pxo", .name = "pxo_board" },
         |                                      ^~~~~
   drivers/clk/qcom/lcc-ipq806x.c:38:38: note: (near initialization for '(anonymous)[0]')
   drivers/clk/qcom/lcc-ipq806x.c:38:45: error: field name not in record or union initializer
      38 |                         { .fw_name = "pxo", .name = "pxo_board" },
         |                                             ^
   drivers/clk/qcom/lcc-ipq806x.c:38:45: note: (near initialization for '(anonymous)[0]')
   drivers/clk/qcom/lcc-ipq806x.c:38:53: warning: excess elements in scalar initializer
      38 |                         { .fw_name = "pxo", .name = "pxo_board" },
         |                                                     ^~~~~~~~~~~
   drivers/clk/qcom/lcc-ipq806x.c:38:53: note: (near initialization for '(anonymous)[0]')
>> drivers/clk/qcom/lcc-ipq806x.c:37:32: error: initialization of 'const struct clk_parent_data *' from incompatible pointer type 'const struct clk_parent_data **' [-Werror=incompatible-pointer-types]
      37 |                 .parent_data = (const struct clk_parent_data*[]){
         |                                ^
   drivers/clk/qcom/lcc-ipq806x.c:37:32: note: (near initialization for '(anonymous).parent_data')
   cc1: some warnings being treated as errors


vim +37 drivers/clk/qcom/lcc-ipq806x.c

    26	
    27	static struct clk_pll pll4 = {
    28		.l_reg = 0x4,
    29		.m_reg = 0x8,
    30		.n_reg = 0xc,
    31		.config_reg = 0x14,
    32		.mode_reg = 0x0,
    33		.status_reg = 0x18,
    34		.status_bit = 16,
    35		.clkr.hw.init = &(struct clk_init_data){
    36			.name = "pll4",
  > 37			.parent_data = (const struct clk_parent_data*[]){
  > 38				{ .fw_name = "pxo", .name = "pxo_board" },
    39			},
    40			.num_parents = 1,
    41			.ops = &clk_pll_ops,
    42		},
    43	};
    44	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp