linux-kernel - Re: [PATCH] eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 21:06:49 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] eeprom: idt_89hpesx: uninitialized data in
 idt_dbgfs_csr_write()

Hi Dan

On Wed, Jul 06, 2022 at 01:40:24PM +0300, Dan Carpenter wrote:
> On Wed, Jul 06, 2022 at 09:58:51AM +0300, Dan Carpenter wrote:
> > The simple_write_to_buffer() here is used to copy a string from the
> > user.  However the function call will succeed if it manages to read
> > just one byte anywhere within the buffer while we need the whole string
> > to be initialized to avoid using uninitialized data.
> > 
> > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> 
> NAK.  The strndup_user() function is too strict.  I will resend this
> using memdup_user() instead.

Thanks for the patch. Ok. I'll wait for v2 to review.

-Sergey

> 
> regards,
> dan carpenter
>