linux-kernel - Re: [BUG] USB broken on rk3568 based R2Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 15:41:08 -0400
From:   Peter Geis <pgwipeout@...il.com>
To:     Frank Wunderlich <frank-w@...lic-files.de>
Cc:     Samuel Holland <samuel@...lland.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vinod Koul <vkoul@...nel.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-phy@...ts.infradead.org>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Heiko Stuebner <heiko@...ech.de>
Subject: Re: [BUG] USB broken on rk3568 based R2Pro

On Thu, Jul 7, 2022 at 1:51 PM Frank Wunderlich <frank-w@...lic-files.de> wrote:
>
> Hi,
>
> traced it down with manual reverts to this one:
>
> commit 6a98df08ccd55e87947d253b19925691763e755c
>     phy: rockchip-inno-usb2: Fix muxed interrupt support
>
> luckily i can revert only this and now upper usb-port works again
>
> @samuel: have you an idea how to fix your problem without breaking my board? :)
>
> @greg/Vinod: maybe we can add a revert of this in mainline till issue is resolved?
>
> regards Frank

I don't know what you're running, but with the standard arm64
defconfig w/ all rockchip stuff built in, I have no issues here on
5.19.
Note, the following changes are necessary to the 5.19 dts here:
Remove the extcon from usb_host0_xhci, as the production model doesn't
have automatic switching capabilities. The ID pin was removed in favor
of the usb debug function which also doesn't work.
Add dr_mode = "host" to the same node, for the same reason.

>
>
> > Von: "Frank Wunderlich" <frank-w@...lic-files.de>
> > i noticed that upper usb-Port (otg) is broken on my Bananapi R2Pro with 5.19-rc1, works with 5.18.0
> >
> > this port is a usb3 (xhci) port which includes an usb2-phy and should support otg, but i still want
> > to use it in host-only mode (USB-A socket).
> >
> > already tried setting dr_mode in dts back to "host" as this was changed in rk356x.dtsi by this commit:
> >
> > bc405bb3eeee 2022-04-25 arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x
> >
> > i see no error in dmesg and usb-controllers seem to be initialized completely (visible in lsusb).
> >
> > r2pro has ID-Pin not connected, so i tried also peters Patch without success :(
>