lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Jul 2022 15:15:37 -0700 From: Kuniyuki Iwashima <kuniyu@...zon.com> To: <paul@...l-moore.com> CC: <davem@...emloft.net>, <edumazet@...gle.com>, <keescook@...omium.org>, <kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>, <linux-kernel@...r.kernel.org>, <mcgrof@...nel.org>, <netdev@...r.kernel.org>, <pabeni@...hat.com>, <yzaikin@...gle.com> Subject: Re: [PATCH v2 net 10/12] cipso: Fix data-races around sysctl. From: Paul Moore <paul@...l-moore.com> Date: Thu, 7 Jul 2022 15:15:52 -0400 > On Wed, Jul 6, 2022 at 7:43 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote: > > > > While reading cipso sysctl variables, they can be changed concurrently. > > So, we need to add READ_ONCE() to avoid data-races. > > > > Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine") > > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com> > > --- > > CC: Paul Moore <paul@...l-moore.com> > > Thanks for the patch, this looks good to me. However, in the future > you should probably drop the extra "---" separator (just leave the one > before the diffstat below) and move my "Cc:" up above "Fixes:". > > Acked-by: Paul Moore <paul@...l-moore.com> I was wondering if both CC and Acked-by should stay in each commit, but will do so in the next time. Thank you for taking a look!
Powered by blists - more mailing lists