linux-kernel - RE: [EXT] RE: [PATCH v3 19/24] dmaengine: dw-edma: Use non-atomic io-64 methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 00:35:55 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Frank Li <frank.li@....com>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Krzysztof Wilczyński <kw@...ux.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jingoo Han <jingoohan1@...il.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: RE: [EXT] RE: [PATCH v3 19/24] dmaengine: dw-edma: Use non-atomic
 io-64 methods

Hi,

> From: Frank Li, Sent: Wednesday, July 6, 2022 11:29 PM
> 
> > > From: Serge Semin, Sent: Friday, June 10, 2022 6:15 PM
<snip>
> >
> > Since both codes in #ifdef and #else are the same, we can just remove code
> > of the #else part.
> > But, what do you think?
> > -----
> >                 #ifdef CONFIG_64BIT
> >                 /* llp is not aligned on 64bit -> keep 32bit accesses */
> >                 SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
> >                           lower_32_bits(chunk->ll_region.paddr));
> >                 SET_CH_32(dw, chan->dir, chan->id, llp.msb,
> >                           upper_32_bits(chunk->ll_region.paddr));
> >                 #else /* CONFIG_64BIT */
> >                 SET_CH_32(dw, chan->dir, chan->id, llp.lsb,
> >                           lower_32_bits(chunk->ll_region.paddr));
> >                 SET_CH_32(dw, chan->dir, chan->id, llp.msb,
> >                           upper_32_bits(chunk->ll_region.paddr));
> >                 #endif /* CONFIG_64BIT */
> > -----
> >
> 
> Latest Linux-next code have removed CONFIG_64BIT.

Thank you for the information! I had looked the PCI repository only.
I confirmed the latest Linux-next (next-20220706 tag) code have removed the CONFIG_64BIT.

Best regards,
Yoshihiro Shimoda