linux-kernel - Re: [PATCH v5 1/3] dt-bindings: clock: Add resets for LPASS audio clock controller for SC7280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 11:31:48 +0530
From:   Taniya Das <quic_tdas@...cinc.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-soc@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <robh@...nel.org>,
        <robh+dt@...nel.org>, <mka@...omium.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: clock: Add resets for LPASS audio
 clock controller for SC7280

Hi Stephen,

On 6/16/2022 1:29 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2022-06-14 08:33:04)
>> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
>> for SC7280. Update reg property min/max items in YAML schema.
>>
>> Fixes: 4185b27b3bef ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280").
>> Acked-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>> ---
>>   .../clock/qcom,sc7280-lpasscorecc.yaml        | 19 ++++++++++++++++---
>>   .../clock/qcom,lpassaudiocc-sc7280.h          |  5 +++++
>>   2 files changed, 21 insertions(+), 3 deletions(-)
> 
> I'm still wondering if the binding is correct, given the overlapping reg
> properties. Should we be removing a compatible or two and adding a DT
> property like "qcom,adsp-bypass-mode" instead?

I can pick this up as cleanup and send it across for review. If you are 
fine now please help pick these up.

-- 
Thanks & Regards,
Taniya Das.