linux-kernel - Re: [PATCH v12 3/7] arm64: dts: allwinner: Add Allwinner H616 .dtsi file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 01:36:31 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Andre Przywara <andre.przywara@....com>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 3/7] arm64: dts: allwinner: Add Allwinner H616 .dtsi
 file

Hi Andre,

On 7/5/22 5:42 AM, Andre Przywara wrote:
> On Mon, 4 Jul 2022 20:16:50 -0500
> Samuel Holland <samuel@...lland.org> wrote:
>>> +		i2c0: i2c@...2000 {
>>> +			compatible = "allwinner,sun50i-h616-i2c",
>>> +				     "allwinner,sun6i-a31-i2c";  
>>
>> Future note: this will be affected by [1] which adds a fallback compatible for
>> variants with offload support. That way we don't have to support them all
>> individually in the driver if/when we implement that.
>>
>> [1]: https://lore.kernel.org/lkml/20220702052544.31443-1-samuel@sholland.org/
> 
> I saw (and liked) that. Shall I insert the compatible string already? Or
> is it too early for that, because dtbs_checks would fail without the
> amended binding in the tree?

The updated binding is in linux-next, so please add the new compatible.

Regards,
Samuel