linux-kernel - Re: [PATCH] sched/fair: fix case with reduced capacity CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 08:42:59 +0200
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     David Chen <david.chen@...anix.com>
Cc:     Zhang Qiao <zhangqiao22@...wei.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "dietmar.eggemann@....com" <dietmar.eggemann@....com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "bsegall@...gle.com" <bsegall@...gle.com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "bristot@...hat.com" <bristot@...hat.com>,
        "vschneid@...hat.com" <vschneid@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/fair: fix case with reduced capacity CPU

On Wed, 6 Jul 2022 at 01:50, David Chen <david.chen@...anix.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Zhang Qiao <zhangqiao22@...wei.com>
> > Sent: Tuesday, July 5, 2022 1:23 AM
> > To: Vincent Guittot <vincent.guittot@...aro.org>
> > Cc: mingo@...hat.com; peterz@...radead.org; juri.lelli@...hat.com; dietmar.eggemann@....com; rostedt@...dmis.org;
> > bsegall@...gle.com; mgorman@...e.de; bristot@...hat.com; vschneid@...hat.com; linux-kernel@...r.kernel.org; David Chen
> > <david.chen@...anix.com>
> > Subject: Re: [PATCH] sched/fair: fix case with reduced capacity CPU
> >
> >
> >
> > 在 2022/7/2 12:52, Vincent Guittot 写道:
> > > The capacity of the CPU available for CFS tasks can be reduced because of
> > > other activities running on the latter. In such case, it's worth trying to
> > > move CFS tasks on a CPU with more available capacity.
> > >
> > > The rework of the load balance has filterd the case when the CPU is
> > > classified to be fully busy but its capacity is reduced.
> > >
> > > Check if CPU's capacity is reduced while gathering load balance statistics
> > > and classify it group_misfit_task instead of group_fully_busy so we can
> > > try to move the load on another CPU.
> > >
> > > Reported-by: David Chen <david.chen@...anix.com>
> > > Reported-by: Zhang Qiao <zhangqiao22@...wei.com>
> > > Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
> > > ---
> > >
> > > David, Zhang,
> > >
> > > I haven't put your tested-by because I have reworked and cleaned the patch to
> > > cover more cases.
> > >
> > > Could you run some tests with this version ?
> >
> > I tested with this version, it is ok.
> >
> > Tested-by: Zhang Qiao <zhangqiao22@...wei.com>
> >
> > Thanks
>
> This version works fine with me.
> Tested-by: David Chen <david.chen@...anix.com>

Thanks

>
> Thanks
>

> > >