linux-kernel - Re: [PATCH] Revert "arm64: dts: qcom: Fix 'reg-names' for sdhci nodes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 09:02:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Douglas Anderson <dianders@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     swboyd@...omium.org, Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "arm64: dts: qcom: Fix 'reg-names' for sdhci
 nodes"

On 06/07/2022 23:47, Douglas Anderson wrote:
> This reverts commit afcbe252e9c19161e4d4c95f33faaf592f1de086.
> 
> The commit in question caused my sc7280-herobrine-herobrine-r1 board
> not to boot anymore. This shouldn't be too surprising since the driver
> is relying on the name "cqhci".

Thanks for finding the issue.

> 
> The issue seems to be that someone decided to change the names of
> things when the binding moved from .txt to .yaml. We should go back to
> the names that the bindings have historically specified.
> 
> For some history, see commit d3392339cae9 ("mmc: cqhci: Update cqhci
> memory ioresource name") and commit d79100c91ae5 ("dt-bindings: mmc:
> sdhci-msm: Add CQE reg map").
> 
> Fixes: afcbe252e9c1 ("arm64: dts: qcom: Fix 'reg-names' for sdhci nodes")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> This is just a straight revert. That presumably means we'll get some
> "make dtbs_check" warnings that were fixed by the commit being
> reverted. I'll leave it to the authors of the original commit to
> adjust the bindings to fix those.

Thanks for the report. I can help here.

Best regards,
Krzysztof