[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 7 Jul 2022 09:55:07 +0200
From: Christian König <christian.koenig@....com>
To: jie1zhan <jesse.zhang@....com>, broonie@...nel.org,
dri-devel-bounces@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org
Cc: Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
Sunil-kumar.Dommati@....com, ajitkumar.pandey@....com,
lucas.demarchi@...el.com, nirmoy.das@...ux.intel.com,
lionel.g.landwerlin@...el.com,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] drm/syncobj: Fix sync syncobj issue
Am 07.07.22 um 05:08 schrieb jie1zhan:
> enable signaling after flatten dma_fence_chains on transfer
>
> Signed-off-by: jie1zhan <jesse.zhang@....com>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
> Reviewed-by: Nirmoy Das <nirmoy.das@...ux.intel.com>
Well please drop those Reviewed-by lines immediately! Neither Nirmoy nor
me gave you the permission to add an rb to this patch. It looks like you
have a major misunderstanding when to add that.
> ---
> drivers/gpu/drm/drm_syncobj.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 7e48dcd1bee4..0d9d3577325f 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
> if (ret)
> goto err_free_fence;
>
> + dma_fence_enable_sw_signaling(fence);
That looks better, but ideally we would enable signaling when the fence
is retrieved from the drm_syncobj and queried for it's signaled state.
Regards,
Christian.
> chain = dma_fence_chain_alloc();
> if (!chain) {
> ret = -ENOMEM;
Powered by blists - more mailing lists