linux-kernel - Re: [PATCH] char: misc: make misc_open() and misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 10:04:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     Oliver Neukum <oneukum@...e.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Wedson Almeida Filho <wedsonaf@...gle.com>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, Dmitry Vyukov <dvyukov@...gle.com>,
        Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH] char: misc: make misc_open() and misc_register() killable

On Thu, Jul 07, 2022 at 02:06:38PM +0900, Tetsuo Handa wrote:
> On 2022/07/06 20:04, Oliver Neukum wrote:
> > 
> > 
> > On 06.07.22 12:26, Tetsuo Handa wrote:
> >> On 2022/07/06 15:34, Greg KH wrote:
> >>> On Wed, Jul 06, 2022 at 03:21:15PM +0900, Tetsuo Handa wrote:
> >>>> How should we fix this problem?
> >>>
> >>> We can decrease the timeout in usb_stor_msg_common().  I imagine that if
> >>> that timeout is ever hit in this sequence, then all will recover, right?
> > 
> > Not really. The timeout there is supposed to come from the SCSI layer
> > in the general case.
> 
> I couldn't catch. usb_stor_msg_common() belongs to USB subsystem, doesn't it?
> 
> How does SCSI layer matter here?
> Does USB storage device shows up as if SCSI disk (e.g. /dev/sdb) relevant?

Yes.  USB storage is a very tiny wrapper around the whole SCSI protocol,
it is a SCSI disk for all all intensive purposes.

thanks,

greg k-h