linux-kernel - [PATCH 0/3] xtensa: iss/network initialization error path fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  7 Jul 2022 01:07:58 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     linux-xtensa@...ux-xtensa.org
Cc:     Chris Zankel <chris@...kel.net>, linux-kernel@...r.kernel.org,
        Yang Yingliang <yangyingliang@...wei.com>,
        Max Filippov <jcmvbkbc@...il.com>
Subject: [PATCH 0/3] xtensa: iss/network initialization error path fixes

Hello,

this series cleans up xtensa ISS network driver and fixes memory leaks
in initialization error paths.
The series was prompted by the patch [1] from Yang Yingliang, but that
patch alone has issues:
- a newly created net_device was added to a list of devices and not
  removed from it in case of error leading to UAF. The way the device
  list was used in the driver doesn't make much sense, so patch 1
  removes it altogether.
- a call to platform_device_unregister would complain that iss-netdev
  does not have a release() function and must be fixed. Patch 2 adds the
  release function for the iss-netdev platform device.
- a proper release() function for the platform device must free the
  net_device object, so the error path that calls
  platform_device_unregister must not call free_netdev afterwards to
  avoid double free. I've modified the patch 3 so that it does that and
  updated the description.

[1] https://lore.kernel.org/lkml/20220707023229.2580893-1-yangyingliang@huawei.com/

Max Filippov (2):
  xtensa: iss/network: drop 'devices' list
  xtensa: iss/network: provide release() callback

Yang Yingliang (1):
  xtensa: iss: fix handling error cases in iss_net_configure()

 arch/xtensa/platforms/iss/network.c | 63 +++++++++++++----------------
 1 file changed, 28 insertions(+), 35 deletions(-)

-- 
2.30.2