linux-kernel - Re: [PATCH v2 0/4] Energy Model power in micro-Watts and SCMI v3.1 alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 11:46:59 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     rafael@...nel.org
Cc:     daniel.lezcano@...aro.org, amitk@...nel.org,
        linux-pm@...r.kernel.org, rui.zhang@...el.com,
        viresh.kumar@...aro.org, dietmar.eggemann@....com, nm@...com,
        sboyd@...nel.org, linux-kernel@...r.kernel.org,
        sudeep.holla@....com, cristian.marussi@....com,
        matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 0/4] Energy Model power in micro-Watts and SCMI v3.1
 alignment

Hi Rafael,

On 7/7/22 08:15, Lukasz Luba wrote:
> Hi all,
> 
> This is a patch set which changes Energy Model power values scale to
> micro-Watts. It also upgrades the SCMI performance layer + scmi-cpufreq
> driver to leverage the SCMI v3.1 spec and process micro-Watts power values
> coming from FW. The higher precision in EM power field solves an issue
> of a rounding error, which then can be misinterpreted as 'inefficient OPP'.
> An example rounding issue calculation is present in patch 1/4 description.
> 
> Changes:
> v2
> - simplified 32bit checks for max number of CPUs preventing energy
>    estimation overflow
> - added Reviewed-by and ACKs
> v1 [1]
> 
> Regards,
> Lukasz Luba
> 
> [1] https://lore.kernel.org/lkml/20220622145802.13032-1-lukasz.luba@arm.com/
> 
> Lukasz Luba (4):
>    PM: EM: convert power field to micro-Watts precision and align drivers
>    Documentation: EM: Switch to micro-Watts scale
>    firmware: arm_scmi: Get detailed power scale from perf
>    cpufreq: scmi: Support the power scale in micro-Watts in SCMI v3.1
> 
>   Documentation/power/energy-model.rst  | 14 +++----
>   drivers/cpufreq/mediatek-cpufreq-hw.c |  7 ++--
>   drivers/cpufreq/scmi-cpufreq.c        | 15 +++++++-
>   drivers/firmware/arm_scmi/perf.c      | 18 +++++----
>   drivers/opp/of.c                      | 15 ++++----
>   drivers/powercap/dtpm_cpu.c           |  5 +--
>   drivers/thermal/cpufreq_cooling.c     | 13 ++++++-
>   drivers/thermal/devfreq_cooling.c     | 19 ++++++++--
>   include/linux/energy_model.h          | 54 +++++++++++++++++++--------
>   include/linux/scmi_protocol.h         |  8 +++-
>   kernel/power/energy_model.c           | 24 ++++++++----
>   11 files changed, 132 insertions(+), 60 deletions(-)
> 

I got ACKs (and on Reviewed-by) for this patch set.
Could you take this via your PM tree, please?